Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): expose alert fingerprint in the API response #1913

Merged
merged 4 commits into from
Jun 30, 2020
Merged

Conversation

prymitive
Copy link
Owner

No description provided.

@prymitive
Copy link
Owner Author

prymitive commented Jun 30, 2020

Go benchmark diff

name                               old time/op        new time/op        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           5.35ms ± 2%        5.30ms ± 1%    ~     (p=0.133 n=9+10)
Decompress/Run-2                         3.82ms ± 2%        3.83ms ± 0%    ~     (p=0.965 n=10+8)
CompressionAndDecompression/Run-2        9.65ms ± 2%        9.72ms ± 1%    ~     (p=0.165 n=10+10)
PullAlerts/0.17.0-2                      6.25ms ± 5%        6.15ms ± 3%    ~     (p=0.497 n=10+9)
AlertsAPIMisses/0.17.0-2                 1.39ms ± 3%        1.41ms ± 4%    ~     (p=0.247 n=10+10)
AlertsAPIHits/0.17.0-2                    903µs ± 2%         953µs ± 9%  +5.57%  (p=0.000 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                         169µs ± 2%         184µs ± 3%  +8.91%  (p=0.000 n=9+10)
DedupAutocomplete/Run-2                  98.6µs ± 1%       100.7µs ± 2%  +2.12%  (p=0.000 n=10+10)
DedupColors/Run-2                        25.4µs ± 1%        25.7µs ± 1%  +1.02%  (p=0.001 n=10+9)

name                               old %/compression  new %/compression  delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             0.04 ± 0%          0.04 ± 0%    ~     (all equal)

name                               old B/alloc        new B/alloc        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                            4.91M ± 0%         4.91M ± 0%  +0.05%  (p=0.000 n=9+9)
Decompress/Run-2                          3.02M ± 0%         3.03M ± 0%  +0.14%  (p=0.000 n=9+10)
CompressionAndDecompression/Run-2         4.92M ± 0%         4.92M ± 0%  +0.16%  (p=0.000 n=10+9)
PullAlerts/0.17.0-2                       2.98M ± 0%         2.99M ± 0%  +0.18%  (p=0.000 n=10+9)
AlertsAPIMisses/0.17.0-2                  3.38M ± 0%         3.38M ± 0%  +0.15%  (p=0.000 n=7+9)
AlertsAPIHits/0.17.0-2                    3.34M ± 0%         3.34M ± 0%  +0.14%  (p=0.000 n=9+8)

name                               old alloc/op       new alloc/op       delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           1.13MB ± 0%        1.13MB ± 0%    ~     (all equal)
Decompress/Run-2                         4.24MB ± 0%        4.24MB ± 0%    ~     (p=0.926 n=10+10)
CompressionAndDecompression/Run-2        5.38MB ± 0%        5.38MB ± 0%  -0.00%  (p=0.033 n=10+10)
PullAlerts/0.17.0-2                      1.26MB ± 0%        1.27MB ± 0%  +0.93%  (p=0.000 n=9+9)
AlertsAPIMisses/0.17.0-2                 1.29MB ± 0%        1.30MB ± 0%  +0.82%  (p=0.000 n=10+9)
AlertsAPIHits/0.17.0-2                    313kB ± 1%         317kB ± 1%  +1.15%  (p=0.000 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                         108kB ± 0%         114kB ± 0%  +5.96%  (p=0.000 n=10+10)
DedupAutocomplete/Run-2                  44.8kB ± 0%        44.8kB ± 0%    ~     (p=0.212 n=10+10)
DedupColors/Run-2                        11.0kB ± 0%        11.0kB ± 0%    ~     (p=0.296 n=10+10)

name                               old allocs/op      new allocs/op      delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             31.0 ± 0%          31.0 ± 0%    ~     (all equal)
Decompress/Run-2                           80.0 ± 0%          80.0 ± 0%    ~     (all equal)
CompressionAndDecompression/Run-2           111 ± 0%           111 ± 0%    ~     (all equal)
PullAlerts/0.17.0-2                       22.5k ± 0%         22.6k ± 0%  +0.65%  (p=0.000 n=9+10)
AlertsAPIMisses/0.17.0-2                  5.98k ± 0%         6.08k ± 0%  +1.65%  (p=0.000 n=10+10)
AlertsAPIHits/0.17.0-2                    2.33k ± 0%         2.35k ± 0%  +0.96%  (p=0.000 n=8+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                           445 ± 0%           445 ± 0%    ~     (all equal)
DedupAutocomplete/Run-2                     142 ± 0%           142 ± 0%    ~     (all equal)
DedupColors/Run-2                          51.0 ± 0%          51.0 ± 0%    ~     (all equal)

@prymitive
Copy link
Owner Author

prymitive commented Jun 30, 2020

Webpack bundle size diff

Total diff: +1.6 KB

M build/static/js/12.66b213f4.chunk.js 34.4 KB 35.3 KB +950 B
M [no source] 1.2 KB 1.2 KB +10 B
M Common 1.2 KB 1.2 KB +27 B
M Components/Grid/AlertGrid/AlertGroup/Alert 4.4 KB 4.3 KB -52 B
+ Components/InhibitedByModal 965 B +965 B
M build/static/js/16.8a2335db.chunk.js 29.2 KB 28.6 KB -672 B
M Components/SilenceModal/SilencePreview 1.4 KB 729 B -672 B
M build/static/js/3.b1b74dab.chunk.js 22 KB 22.5 KB +575 B
M Components/LabelSetList 1.1 KB 1.2 KB +81 B
M Components/ManagedSilence 10.5 KB 10.2 KB -291 B
M [no source] 1.5 KB 1.5 KB -10 B
+ Components/PaginatedAlertList 795 B +795 B
+ build/static/js/20.b97a04d5.chunk.js 777 B +777 B
+ Components/InhibitedByModal 640 B +640 B
+ [sourceMappingURL] 45 B +45 B
+ [unmapped] 91 B +91 B
+ [EOLs] 1 B +1 B

@prymitive prymitive merged commit 54573a2 into master Jun 30, 2020
@prymitive prymitive deleted the finterprints branch June 30, 2020 22:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant