Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): improve alertmanager cluster handling #2158

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

prymitive
Copy link
Owner

Always use passed cluster name, generate errors if cluster is in unhealthy state

Always use passed cluster name, generate errors if cluster is in unhealthy state
@prymitive prymitive force-pushed the refactor-cluster-errors branch from f7cdfcb to d333824 Compare September 8, 2020 16:34
@prymitive
Copy link
Owner Author

Go benchmark diff

name                               old time/op        new time/op        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           5.40ms ± 1%        5.25ms ± 3%  -2.78%  (p=0.002 n=10+10)
Decompress/Run-2                         3.68ms ± 1%        3.63ms ± 1%  -1.35%  (p=0.001 n=9+9)
CompressionAndDecompression/Run-2        9.40ms ± 0%        9.36ms ± 2%    ~     (p=0.604 n=9+10)
PullAlerts/0.19.0-2                      6.24ms ± 1%        6.15ms ± 3%  -1.35%  (p=0.043 n=10+10)
AlertsAPIMisses/0.19.0-2                 1.51ms ± 3%        1.44ms ± 3%  -4.32%  (p=0.000 n=10+10)
AlertsAPIHits/0.19.0-2                    951µs ± 3%         933µs ± 2%  -1.85%  (p=0.019 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                         129µs ± 2%         128µs ± 2%    ~     (p=0.190 n=10+10)
DedupAutocomplete/Run-2                  59.8µs ± 1%        59.0µs ± 1%  -1.38%  (p=0.000 n=9+9)
DedupColors/Run-2                        17.1µs ± 3%        16.7µs ± 1%  -2.18%  (p=0.003 n=9+9)

name                               old %/compression  new %/compression  delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             0.04 ± 0%          0.04 ± 0%    ~     (all equal)

name                               old B/alloc        new B/alloc        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                            4.99M ± 0%         4.99M ± 0%  -0.00%  (p=0.009 n=9+9)
Decompress/Run-2                          3.10M ± 0%         3.10M ± 0%  +0.13%  (p=0.012 n=10+9)
CompressionAndDecompression/Run-2         5.00M ± 0%         5.00M ± 0%    ~     (p=0.107 n=10+9)
PullAlerts/0.19.0-2                       3.06M ± 0%         3.06M ± 0%  -0.11%  (p=0.000 n=9+8)
AlertsAPIMisses/0.19.0-2                  3.46M ± 0%         3.45M ± 0%  -0.07%  (p=0.000 n=9+9)
AlertsAPIHits/0.19.0-2                    3.42M ± 0%         3.42M ± 0%  -0.07%  (p=0.000 n=9+9)

name                               old alloc/op       new alloc/op       delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           1.13MB ± 0%        1.13MB ± 0%    ~     (all equal)
Decompress/Run-2                         4.24MB ± 0%        4.24MB ± 0%    ~     (p=0.650 n=10+10)
CompressionAndDecompression/Run-2        5.38MB ± 0%        5.38MB ± 0%    ~     (all equal)
PullAlerts/0.19.0-2                      1.27MB ± 0%        1.27MB ± 0%    ~     (p=0.139 n=10+9)
AlertsAPIMisses/0.19.0-2                 1.29MB ± 0%        1.29MB ± 0%    ~     (p=0.243 n=9+10)
AlertsAPIHits/0.19.0-2                    317kB ± 1%         317kB ± 1%    ~     (p=0.905 n=9+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                        73.7kB ± 0%        73.7kB ± 0%    ~     (p=0.159 n=10+9)
DedupAutocomplete/Run-2                  28.2kB ± 0%        27.2kB ± 0%  -3.58%  (p=0.000 n=10+10)
DedupColors/Run-2                        7.36kB ± 0%        7.36kB ± 0%    ~     (all equal)

name                               old allocs/op      new allocs/op      delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             31.0 ± 0%          31.0 ± 0%    ~     (all equal)
Decompress/Run-2                           80.0 ± 0%          80.0 ± 0%    ~     (all equal)
CompressionAndDecompression/Run-2           111 ± 0%           111 ± 0%    ~     (all equal)
PullAlerts/0.19.0-2                       22.5k ± 0%         22.5k ± 0%    ~     (all equal)
AlertsAPIMisses/0.19.0-2                  6.08k ± 0%         6.08k ± 0%  +0.12%  (p=0.000 n=10+10)
AlertsAPIHits/0.19.0-2                    2.35k ± 0%         2.36k ± 0%  +0.29%  (p=0.000 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                           415 ± 0%           415 ± 0%    ~     (all equal)
DedupAutocomplete/Run-2                     119 ± 0%           114 ± 0%  -4.20%  (p=0.000 n=10+10)
DedupColors/Run-2                          35.0 ± 0%          35.0 ± 0%    ~     (all equal)

@prymitive prymitive merged commit 757f347 into master Sep 8, 2020
@prymitive prymitive deleted the refactor-cluster-errors branch September 8, 2020 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant