feat(backend): use fewer histogram buckets for request latency #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpett
force-pushed
the
fewer-histogram-buckets
branch
from
6b51191
to
099fd3e
Compare
prymitive
reviewed
Sep 25, 2020
Default buckets cover up to 10 seconds, which is unnecessarily wide
carlpett
force-pushed
the
fewer-histogram-buckets
branch
from
099fd3e
to
6628a4b
Compare
prymitive
approved these changes
Sep 25, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default buckets cover up to 10 seconds, which is unnecessarily wide.
Checking our installation, highest p99.9 among all endpoints is 0.34s (somewhat unexpectedly, the notFound handler).