Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): improve test coverage #2243

Merged
merged 3 commits into from
Oct 4, 2020
Merged

fix(ci): improve test coverage #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
572bb66
fix(ci): improve test coverage
prymitive Oct 4, 2020
03ff846
fix(ci): improve TLS test coverage
prymitive Oct 4, 2020
a07627e
fix(ci): improve test coverage
prymitive Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions cmd/karma/tests/testscript/049_invalid_tls_config.txt
View file
Open in desktop

This file was deleted.

64 changes: 64 additions & 0 deletions cmd/karma/tests/testscript/078_tls_missing_ca.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# Raises an error if tls CA cert is missing

karma.bin-should-fail --pid-file=karma.pid --log.format=text --log.config=true --log.level=info --config.file=karma.yaml --listen.address=127.0.0.1 --listen.port=8078
! stdout .
stderr 'msg="Failed to create HTTP transport for Alertmanager ''client-auth'' with URI ''https:\/\/localhost:9093'': open ca.crt: no such file or directory"'

-- karma.yaml --
alertmanager:
servers:
- name: client-auth
uri: https://localhost:9093
timeout: 10s
tls:
ca: ca.crt
cert: client.pem
key: client.key

-- client.pem --
-----BEGIN CERTIFICATE-----
MIICwzCCAaugAwIBAgIJAJSCPvgy3Fw5MA0GCSqGSIb3DQEBBQUAMBQxEjAQBgNV
BAMTCWxvY2FsaG9zdDAeFw0yMDEwMDQxMTA4MDNaFw0zMDEwMDIxMTA4MDNaMBQx
EjAQBgNVBAMTCWxvY2FsaG9zdDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoC
ggEBAMdKdTkZTh8m1KetGiZPEk0kOoauARiVGIZ0cx+X7CvYpDjFs5e63sFcH57D
G/xtFBk4Q6UcG5/fHti1rmn3mIzreYDh+oOaiSN+MswHW6Sit5HfjCgVOtrZdjcV
VXJmYZerdoB0orMvud7kfbRgsQfJx9G0BpKRRmJo8beEkV2LCIp0Ns8bb7WlmW0R
dFZWyPnWCIrTIONXzyFA7jAwZ8wVewmYNWH1LqvH4BnEkz39VgJoDDJp+WNHez9J
v5fOiqKJwhKvV5Un63DOz+xuwd3ASJRwKqSWTNTIcZazPs9ihdYKOnmqaCfIwFBj
ooh/9Q0ByrA2HH4VVKpHtld0mVcCAwEAAaMYMBYwFAYDVR0RBA0wC4IJbG9jYWxo
b3N0MA0GCSqGSIb3DQEBBQUAA4IBAQB/cSeIdAHuWM9BENmdAlul1jrAegNRK57k
KLcRiirq9dTtusTlzars+DZdPHewHajWsSil2191DyqV3n/zYq/1g9oWYX80jvX1
wSlfM/0T6PWc9miRChVx8mGQc/C7vKE4j4oxRZ9EsZIyqKlrxqWA4UXuOZUSaLWx
nECZRf/ofzcr6wNMdoZ8pQUqW05Jmnr+XiP09UoPHQsct9xfzOUGCB3PT47tVK7b
Hu1PStj2VzTPeSDGv/R8X5bPcUcZIdK7as5MKVu9slmk9QLlUj3C6dmw7VudWisg
CKglns9xWEOEA71DVeTS1ieLYychQdYIfNRMulgU+dC8djN2U/Sc
-----END CERTIFICATE-----

-- client.key --
-----BEGIN RSA PRIVATE KEY-----
MIIEpAIBAAKCAQEAx0p1ORlOHybUp60aJk8STSQ6hq4BGJUYhnRzH5fsK9ikOMWz
l7rewVwfnsMb/G0UGThDpRwbn98e2LWuafeYjOt5gOH6g5qJI34yzAdbpKK3kd+M
KBU62tl2NxVVcmZhl6t2gHSisy+53uR9tGCxB8nH0bQGkpFGYmjxt4SRXYsIinQ2
zxtvtaWZbRF0VlbI+dYIitMg41fPIUDuMDBnzBV7CZg1YfUuq8fgGcSTPf1WAmgM
Mmn5Y0d7P0m/l86KoonCEq9XlSfrcM7P7G7B3cBIlHAqpJZM1MhxlrM+z2KF1go6
eapoJ8jAUGOiiH/1DQHKsDYcfhVUqke2V3SZVwIDAQABAoIBAQCBg7sgy3hAuHyV
J+MJqHONXJEIe8bMkgCpSL6UdqgOarF3D8zCO7iOUu9dvxDOAJmCNlWH1PeC837Z
eWELDtS+KD4Da1jh9ClRvq8Gd3WwTescyvoMBpgEKDUyYRPxz+V2qwDNRH+EEe0q
lLW45unF1PWeK+/lirICPI9yI55Q+mZkFIZHZwqobEsk/7yk0Z+6bQDgTDU4vHYF
GEsWsSlv14DVRPVEUHuNzypvK88CFU2CaEiMRTOXWGVnd80mDA7A+VcuoY85264/
tVU0sVbo/TE9bcVCChHT9HiAN90+MO5BzCT5uqRdtKX2sBjchI+v7EJKraU6FGiC
u6w83LehAoGBAPcNmc4B36PggyAtTHgtOrpgQ/2FrcvmJXMQO3Gv5VqnHDTeiYxI
r5smBDFztbLbnmrXeZXGAYraPSotV0/3Mck48OWA6RxLms6oGl3rP7clDUZBFOCJ
Fjqol6IY1RHOHlbcid/TCspaAuW8wQF50ITl3bwa5v9L+mMXrijcNJ/nAoGBAM6C
DxQhRc9DCKqc5jtrYCFmo0SNZRukRVrTMBnOY16kl6gsYYCSviICa8+Y2epeXaWV
g4VtwwgCGd+vk0iZ4Q/VV/g2bpElpm2+yKXN6NiEuwB7jMDJ/mdhLD7lJZd4r2GD
jUKmrIPFANON4fjgGy2NR8JNZdvkPUXiIbr3hs0RAoGAB704VTi/zb1pvidNHvKj
xVTgrF90q0+BWtJmWlBdSfK0Mn/KJUfdoGmXdgke5wR0OPqZB3UVdUkS43BaLNoc
iCYtfbMFGmrP5atkcA6/hzg06z98rO/+b0X6wgwvGIixcJ0mAIn265HYR2QbU7WC
L7eXs53QIK07ocELJqKHT38CgYBOMULiXWLggsJST8yBbTveCc4CVAOXvtCf/l01
OEe5+1qNTBizJV0m5YHK/lZs/sQ4wW8mY5Q4gQso/oMnN1TXuPFxQ7MD9Jya62Vw
GpJzAXcJTL7T9OgGXu3w9rUQMJs/sh8XwKKL1llkwVFx+fFwgxFLyiCqbTaiMmiR
Mc5x8QKBgQCVGACXeKvgbc7J6hMUQX/ZPK6rv2yQWkTRn84lMD8TxagJIj0wtWGO
dshQeVDq07p2//410J1BVSQiAdwQ+HVmSO4Fqg0DHqmWn4fi1zBnxVvxW62iAV8+
db9yajtsMsgPuw26UY9R33PZIUe+CKWKToipm2XbzPtlrbWblZ/g0Q==
-----END RSA PRIVATE KEY-----
44 changes: 44 additions & 0 deletions cmd/karma/tests/testscript/079_tls_missing_client.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Raises an error if tls CA cert is missing

karma.bin-should-fail --pid-file=karma.pid --log.format=text --log.config=true --log.level=info --config.file=karma.yaml --listen.address=127.0.0.1 --listen.port=8078
! stdout .
stderr 'msg="Failed to create HTTP transport for Alertmanager ''client-auth'' with URI ''https:\/\/localhost:9093'': open client.pem: no such file or directory"'

-- karma.yaml --
alertmanager:
servers:
- name: client-auth
uri: https://localhost:9093
timeout: 10s
tls:
cert: client.pem
key: client.key

-- client.key --
-----BEGIN RSA PRIVATE KEY-----
MIIEpAIBAAKCAQEAx0p1ORlOHybUp60aJk8STSQ6hq4BGJUYhnRzH5fsK9ikOMWz
l7rewVwfnsMb/G0UGThDpRwbn98e2LWuafeYjOt5gOH6g5qJI34yzAdbpKK3kd+M
KBU62tl2NxVVcmZhl6t2gHSisy+53uR9tGCxB8nH0bQGkpFGYmjxt4SRXYsIinQ2
zxtvtaWZbRF0VlbI+dYIitMg41fPIUDuMDBnzBV7CZg1YfUuq8fgGcSTPf1WAmgM
Mmn5Y0d7P0m/l86KoonCEq9XlSfrcM7P7G7B3cBIlHAqpJZM1MhxlrM+z2KF1go6
eapoJ8jAUGOiiH/1DQHKsDYcfhVUqke2V3SZVwIDAQABAoIBAQCBg7sgy3hAuHyV
J+MJqHONXJEIe8bMkgCpSL6UdqgOarF3D8zCO7iOUu9dvxDOAJmCNlWH1PeC837Z
eWELDtS+KD4Da1jh9ClRvq8Gd3WwTescyvoMBpgEKDUyYRPxz+V2qwDNRH+EEe0q
lLW45unF1PWeK+/lirICPI9yI55Q+mZkFIZHZwqobEsk/7yk0Z+6bQDgTDU4vHYF
GEsWsSlv14DVRPVEUHuNzypvK88CFU2CaEiMRTOXWGVnd80mDA7A+VcuoY85264/
tVU0sVbo/TE9bcVCChHT9HiAN90+MO5BzCT5uqRdtKX2sBjchI+v7EJKraU6FGiC
u6w83LehAoGBAPcNmc4B36PggyAtTHgtOrpgQ/2FrcvmJXMQO3Gv5VqnHDTeiYxI
r5smBDFztbLbnmrXeZXGAYraPSotV0/3Mck48OWA6RxLms6oGl3rP7clDUZBFOCJ
Fjqol6IY1RHOHlbcid/TCspaAuW8wQF50ITl3bwa5v9L+mMXrijcNJ/nAoGBAM6C
DxQhRc9DCKqc5jtrYCFmo0SNZRukRVrTMBnOY16kl6gsYYCSviICa8+Y2epeXaWV
g4VtwwgCGd+vk0iZ4Q/VV/g2bpElpm2+yKXN6NiEuwB7jMDJ/mdhLD7lJZd4r2GD
jUKmrIPFANON4fjgGy2NR8JNZdvkPUXiIbr3hs0RAoGAB704VTi/zb1pvidNHvKj
xVTgrF90q0+BWtJmWlBdSfK0Mn/KJUfdoGmXdgke5wR0OPqZB3UVdUkS43BaLNoc
iCYtfbMFGmrP5atkcA6/hzg06z98rO/+b0X6wgwvGIixcJ0mAIn265HYR2QbU7WC
L7eXs53QIK07ocELJqKHT38CgYBOMULiXWLggsJST8yBbTveCc4CVAOXvtCf/l01
OEe5+1qNTBizJV0m5YHK/lZs/sQ4wW8mY5Q4gQso/oMnN1TXuPFxQ7MD9Jya62Vw
GpJzAXcJTL7T9OgGXu3w9rUQMJs/sh8XwKKL1llkwVFx+fFwgxFLyiCqbTaiMmiR
Mc5x8QKBgQCVGACXeKvgbc7J6hMUQX/ZPK6rv2yQWkTRn84lMD8TxagJIj0wtWGO
dshQeVDq07p2//410J1BVSQiAdwQ+HVmSO4Fqg0DHqmWn4fi1zBnxVvxW62iAV8+
db9yajtsMsgPuw26UY9R33PZIUe+CKWKToipm2XbzPtlrbWblZ/g0Q==
-----END RSA PRIVATE KEY-----
34 changes: 34 additions & 0 deletions cmd/karma/tests/testscript/080_tls_missing_key.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Raises an error if tls CA cert is missing

karma.bin-should-fail --pid-file=karma.pid --log.format=text --log.config=true --log.level=info --config.file=karma.yaml --listen.address=127.0.0.1 --listen.port=8078
! stdout .
stderr 'msg="Failed to create HTTP transport for Alertmanager ''client-auth'' with URI ''https:\/\/localhost:9093'': open client.key: no such file or directory"'

-- karma.yaml --
alertmanager:
servers:
- name: client-auth
uri: https://localhost:9093
timeout: 10s
tls:
cert: client.pem
key: client.key

-- client.pem --
-----BEGIN CERTIFICATE-----
MIICwzCCAaugAwIBAgIJAJSCPvgy3Fw5MA0GCSqGSIb3DQEBBQUAMBQxEjAQBgNV
BAMTCWxvY2FsaG9zdDAeFw0yMDEwMDQxMTA4MDNaFw0zMDEwMDIxMTA4MDNaMBQx
EjAQBgNVBAMTCWxvY2FsaG9zdDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoC
ggEBAMdKdTkZTh8m1KetGiZPEk0kOoauARiVGIZ0cx+X7CvYpDjFs5e63sFcH57D
G/xtFBk4Q6UcG5/fHti1rmn3mIzreYDh+oOaiSN+MswHW6Sit5HfjCgVOtrZdjcV
VXJmYZerdoB0orMvud7kfbRgsQfJx9G0BpKRRmJo8beEkV2LCIp0Ns8bb7WlmW0R
dFZWyPnWCIrTIONXzyFA7jAwZ8wVewmYNWH1LqvH4BnEkz39VgJoDDJp+WNHez9J
v5fOiqKJwhKvV5Un63DOz+xuwd3ASJRwKqSWTNTIcZazPs9ihdYKOnmqaCfIwFBj
ooh/9Q0ByrA2HH4VVKpHtld0mVcCAwEAAaMYMBYwFAYDVR0RBA0wC4IJbG9jYWxo
b3N0MA0GCSqGSIb3DQEBBQUAA4IBAQB/cSeIdAHuWM9BENmdAlul1jrAegNRK57k
KLcRiirq9dTtusTlzars+DZdPHewHajWsSil2191DyqV3n/zYq/1g9oWYX80jvX1
wSlfM/0T6PWc9miRChVx8mGQc/C7vKE4j4oxRZ9EsZIyqKlrxqWA4UXuOZUSaLWx
nECZRf/ofzcr6wNMdoZ8pQUqW05Jmnr+XiP09UoPHQsct9xfzOUGCB3PT47tVK7b
Hu1PStj2VzTPeSDGv/R8X5bPcUcZIdK7as5MKVu9slmk9QLlUj3C6dmw7VudWisg
CKglns9xWEOEA71DVeTS1ieLYychQdYIfNRMulgU+dC8djN2U/Sc
-----END CERTIFICATE-----
47 changes: 47 additions & 0 deletions cmd/karma/tests/testscript/081_tls_unparsable_cert.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Raises an error if tls CA cert is missing

karma.bin-should-fail --pid-file=karma.pid --log.format=text --log.config=true --log.level=info --config.file=karma.yaml --listen.address=127.0.0.1 --listen.port=8078
! stdout .
stderr 'msg="Failed to create HTTP transport for Alertmanager ''client-auth'' with URI ''https:\/\/localhost:9093'': tls: failed to find any PEM data in certificate input"'

-- karma.yaml --
alertmanager:
servers:
- name: client-auth
uri: https://localhost:9093
timeout: 10s
tls:
cert: client.pem
key: client.key

-- client.pem --
FOO

-- client.key --
-----BEGIN RSA PRIVATE KEY-----
MIIEpAIBAAKCAQEAx0p1ORlOHybUp60aJk8STSQ6hq4BGJUYhnRzH5fsK9ikOMWz
l7rewVwfnsMb/G0UGThDpRwbn98e2LWuafeYjOt5gOH6g5qJI34yzAdbpKK3kd+M
KBU62tl2NxVVcmZhl6t2gHSisy+53uR9tGCxB8nH0bQGkpFGYmjxt4SRXYsIinQ2
zxtvtaWZbRF0VlbI+dYIitMg41fPIUDuMDBnzBV7CZg1YfUuq8fgGcSTPf1WAmgM
Mmn5Y0d7P0m/l86KoonCEq9XlSfrcM7P7G7B3cBIlHAqpJZM1MhxlrM+z2KF1go6
eapoJ8jAUGOiiH/1DQHKsDYcfhVUqke2V3SZVwIDAQABAoIBAQCBg7sgy3hAuHyV
J+MJqHONXJEIe8bMkgCpSL6UdqgOarF3D8zCO7iOUu9dvxDOAJmCNlWH1PeC837Z
eWELDtS+KD4Da1jh9ClRvq8Gd3WwTescyvoMBpgEKDUyYRPxz+V2qwDNRH+EEe0q
lLW45unF1PWeK+/lirICPI9yI55Q+mZkFIZHZwqobEsk/7yk0Z+6bQDgTDU4vHYF
GEsWsSlv14DVRPVEUHuNzypvK88CFU2CaEiMRTOXWGVnd80mDA7A+VcuoY85264/
tVU0sVbo/TE9bcVCChHT9HiAN90+MO5BzCT5uqRdtKX2sBjchI+v7EJKraU6FGiC
u6w83LehAoGBAPcNmc4B36PggyAtTHgtOrpgQ/2FrcvmJXMQO3Gv5VqnHDTeiYxI
r5smBDFztbLbnmrXeZXGAYraPSotV0/3Mck48OWA6RxLms6oGl3rP7clDUZBFOCJ
Fjqol6IY1RHOHlbcid/TCspaAuW8wQF50ITl3bwa5v9L+mMXrijcNJ/nAoGBAM6C
DxQhRc9DCKqc5jtrYCFmo0SNZRukRVrTMBnOY16kl6gsYYCSviICa8+Y2epeXaWV
g4VtwwgCGd+vk0iZ4Q/VV/g2bpElpm2+yKXN6NiEuwB7jMDJ/mdhLD7lJZd4r2GD
jUKmrIPFANON4fjgGy2NR8JNZdvkPUXiIbr3hs0RAoGAB704VTi/zb1pvidNHvKj
xVTgrF90q0+BWtJmWlBdSfK0Mn/KJUfdoGmXdgke5wR0OPqZB3UVdUkS43BaLNoc
iCYtfbMFGmrP5atkcA6/hzg06z98rO/+b0X6wgwvGIixcJ0mAIn265HYR2QbU7WC
L7eXs53QIK07ocELJqKHT38CgYBOMULiXWLggsJST8yBbTveCc4CVAOXvtCf/l01
OEe5+1qNTBizJV0m5YHK/lZs/sQ4wW8mY5Q4gQso/oMnN1TXuPFxQ7MD9Jya62Vw
GpJzAXcJTL7T9OgGXu3w9rUQMJs/sh8XwKKL1llkwVFx+fFwgxFLyiCqbTaiMmiR
Mc5x8QKBgQCVGACXeKvgbc7J6hMUQX/ZPK6rv2yQWkTRn84lMD8TxagJIj0wtWGO
dshQeVDq07p2//410J1BVSQiAdwQ+HVmSO4Fqg0DHqmWn4fi1zBnxVvxW62iAV8+
db9yajtsMsgPuw26UY9R33PZIUe+CKWKToipm2XbzPtlrbWblZ/g0Q==
-----END RSA PRIVATE KEY-----
37 changes: 37 additions & 0 deletions cmd/karma/tests/testscript/082_tls_unparsable_key.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Raises an error if tls CA cert is missing

karma.bin-should-fail --pid-file=karma.pid --log.format=text --log.config=true --log.level=info --config.file=karma.yaml --listen.address=127.0.0.1 --listen.port=8078
! stdout .
stderr 'msg="Failed to create HTTP transport for Alertmanager ''client-auth'' with URI ''https:\/\/localhost:9093'': tls: failed to find any PEM data in key input"'

-- karma.yaml --
alertmanager:
servers:
- name: client-auth
uri: https://localhost:9093
timeout: 10s
tls:
cert: client.pem
key: client.key

-- client.pem --
-----BEGIN CERTIFICATE-----
MIICwzCCAaugAwIBAgIJAJSCPvgy3Fw5MA0GCSqGSIb3DQEBBQUAMBQxEjAQBgNV
BAMTCWxvY2FsaG9zdDAeFw0yMDEwMDQxMTA4MDNaFw0zMDEwMDIxMTA4MDNaMBQx
EjAQBgNVBAMTCWxvY2FsaG9zdDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoC
ggEBAMdKdTkZTh8m1KetGiZPEk0kOoauARiVGIZ0cx+X7CvYpDjFs5e63sFcH57D
G/xtFBk4Q6UcG5/fHti1rmn3mIzreYDh+oOaiSN+MswHW6Sit5HfjCgVOtrZdjcV
VXJmYZerdoB0orMvud7kfbRgsQfJx9G0BpKRRmJo8beEkV2LCIp0Ns8bb7WlmW0R
dFZWyPnWCIrTIONXzyFA7jAwZ8wVewmYNWH1LqvH4BnEkz39VgJoDDJp+WNHez9J
v5fOiqKJwhKvV5Un63DOz+xuwd3ASJRwKqSWTNTIcZazPs9ihdYKOnmqaCfIwFBj
ooh/9Q0ByrA2HH4VVKpHtld0mVcCAwEAAaMYMBYwFAYDVR0RBA0wC4IJbG9jYWxo
b3N0MA0GCSqGSIb3DQEBBQUAA4IBAQB/cSeIdAHuWM9BENmdAlul1jrAegNRK57k
KLcRiirq9dTtusTlzars+DZdPHewHajWsSil2191DyqV3n/zYq/1g9oWYX80jvX1
wSlfM/0T6PWc9miRChVx8mGQc/C7vKE4j4oxRZ9EsZIyqKlrxqWA4UXuOZUSaLWx
nECZRf/ofzcr6wNMdoZ8pQUqW05Jmnr+XiP09UoPHQsct9xfzOUGCB3PT47tVK7b
Hu1PStj2VzTPeSDGv/R8X5bPcUcZIdK7as5MKVu9slmk9QLlUj3C6dmw7VudWisg
CKglns9xWEOEA71DVeTS1ieLYychQdYIfNRMulgU+dC8djN2U/Sc
-----END CERTIFICATE-----

-- client.key --
FOO
27 changes: 27 additions & 0 deletions internal/alertmanager/model_test.go → internal/alertmanager/models_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,30 @@ func TestAlertmanagerPullWithInvalidURI(t *testing.T) {
t.Error("am.Pull(invalid uri) didn't return any error")
}
}

func TestAlertmanagerPullAlertsWithInvalidVersion(t *testing.T) {
log.SetLevel(log.PanicLevel)
am, _ := NewAlertmanager("cluster", "test", "http://localhost")
err := am.pullAlerts("0.0.1")
if err == nil {
t.Error("am.pullAlerts(invalid version) didn't return any error")
}
}

func TestAlertmanagerPullSilencesWithInvalidVersion(t *testing.T) {
log.SetLevel(log.PanicLevel)
am, _ := NewAlertmanager("cluster", "test", "http://localhost")
err := am.pullSilences("0.0.1")
if err == nil {
t.Error("am.pullSilences(invalid version) didn't return any error")
}
}

func TestAlertmanagerFetchStatusWithInvalidVersion(t *testing.T) {
log.SetLevel(log.PanicLevel)
am, _ := NewAlertmanager("cluster", "test", "http://localhost")
_, err := am.fetchStatus("0.0.1")
if err == nil {
t.Error("am.fetchStatus(invalid version) didn't return any error")
}
}
40 changes: 38 additions & 2 deletions internal/alertmanager/upstream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import (
)

type testCase struct {
config config.AlertmanagerConfig
config config.AlertmanagerConfig
shouldFail bool
}

var testCases = []testCase{
Expand Down Expand Up @@ -49,6 +50,32 @@ var testCases = []testCase{
Headers: map[string]string{},
},
},
{
config: config.AlertmanagerConfig{
Cluster: "cluster",
Name: "name",
URI: "%gh&%ij",
ExternalURI: "http://localhost:9095",
Timeout: time.Second * 30,
Proxy: false,
ReadOnly: true,
Headers: map[string]string{},
},
shouldFail: true,
},
{
config: config.AlertmanagerConfig{
Cluster: "cluster",
Name: "name",
URI: "http://localhost:9095",
ExternalURI: "%gh&%ij",
Timeout: time.Second * 30,
Proxy: false,
ReadOnly: true,
Headers: map[string]string{},
},
shouldFail: true,
},
}

func TestOptions(t *testing.T) {
Expand All @@ -72,9 +99,15 @@ func TestOptions(t *testing.T) {
WithReadOnly(tc.config.ReadOnly),
WithHTTPTransport(httpTransport), // we will pass a nil unless TLS.CA or TLS.Cert is set
WithHTTPHeaders(tc.config.Headers),
WithCORSCredentials(tc.config.CORS.Credentials),
)
didFail := err != nil
if didFail != tc.shouldFail {
t.Errorf("Alertmanager '%s' error mismatch, shouldFail=%v, err=%v", tc.config.Name, tc.shouldFail, err)
}
if err != nil {
t.Errorf("Failed to create Alertmanager '%s' with URI '%s': %s", tc.config.Name, tc.config.URI, err)
t.Logf("Alertmanager '%s' returned an error: %v", tc.config.Name, err)
continue
}
if am.Name != tc.config.Name {
t.Errorf("AlertmanagerConfig with name '%s' returned Alertmanager with name '%s'", tc.config.Name, am.Name)
Expand All @@ -88,5 +121,8 @@ func TestOptions(t *testing.T) {
if am.ReadOnly != tc.config.ReadOnly {
t.Errorf("AlertmanagerConfig with name '%s' and readonly '%v' returned Alertmanager with readonly '%v'", tc.config.Name, tc.config.ReadOnly, am.ReadOnly)
}
if am.CORSCredentials != tc.config.CORS.Credentials {
t.Errorf("AlertmanagerConfig with name '%s' and cors:credentials '%v' returned Alertmanager with cors:credentials '%v'", tc.config.Name, tc.config.CORS.Credentials, am.CORSCredentials)
}
}
}