Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to new GitHub Container Registry #2244

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

carlpett
Copy link
Contributor

@carlpett carlpett commented Oct 5, 2020

This PR adds a push to the "new" Github Container Registry (I kept the push to the "old" Github Package Registry since I guess people may have workflow dependencies on it?).

The new registry has two benefits:

@prymitive
Copy link
Owner

According to Github stats nobody is using docker repo on Github, so I was actually considering dropping it. But maybe that will change after Docker Hub enforces authenticated pulls.

@prymitive prymitive merged commit b1cc4c6 into prymitive:master Oct 6, 2020
@prymitive
Copy link
Owner

Thanks

@carlpett
Copy link
Contributor Author

carlpett commented Oct 6, 2020

According to Github stats nobody is using docker repo on Github

We've been using it 🙂 But we mirror images we use to an internal registry, so we'll only show up as a single pull (and haven't bumped to 0.71 yet).
I'll admit we didn't find the image on Docker Hub - I somehow missed the reference in the readme and assumed it would've been hosted under the prymitive name on Docker Hub as well...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants