fix(backend): correctly handle AUTHENTICATION_HEADER_VALUE_RE env variable #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable SILENCEFORM_AUTHOR_POPULATE_FROM_HEADER_* env support was removed, but old code is still present, remove it. Correctly parse AUTHENTICATION_HEADER_VALUE_RE env variable into authentication.header.value_re config option. Fixes #2246
candlerb
reviewed
Oct 6, 2020
| case "SILENCEFORM_AUTHOR_POPULATE_FROM_HEADER_VALUE_RE": | ||
| return "silenceForm.author.populate_from_header.value_re" | ||
| case "AUTHENTICATION_HEADER_VALUE_RE": | ||
| return "authentication.header.value_re" |
There was a problem hiding this comment.
Is AUTHENTICATION_HEADER_NAME needed here as well?
There was a problem hiding this comment.
No, this whole section is only needed because all underscores are converted to dots. So AUTHENTICATION_HEADER_VALUE_RE becomes authentication.header.value.re while [...].value_re is needed.
A better naming convention would avoid this whole problem.
|
Go benchmark diff |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILENCEFORM_AUTHOR_POPULATE_FROM_HEADER_* env support was removed, but old code is still present, remove it.
Correctly parse AUTHENTICATION_HEADER_VALUE_RE env variable into authentication.header.value_re config option.
Fixes #2246