Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): simplify version probes #2337

Merged
merged 6 commits into from
Oct 30, 2020
Merged

fix(backend): simplify version probes #2337

merged 6 commits into from
Oct 30, 2020

Conversation

prymitive
Copy link
Owner

No description provided.

@prymitive
Copy link
Owner Author

prymitive commented Oct 30, 2020

Go benchmark diff

name                               old time/op        new time/op        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           5.04ms ± 2%        5.06ms ± 1%    ~     (p=0.278 n=9+10)
Decompress/Run-2                         3.43ms ± 1%        3.44ms ± 1%    ~     (p=0.739 n=10+10)
CompressionAndDecompression/Run-2        8.89ms ± 1%        9.02ms ± 2%  +1.46%  (p=0.000 n=10+10)
PullAlerts/0.19.0-2                      5.68ms ± 2%        5.82ms ± 1%  +2.41%  (p=0.000 n=10+9)
AlertsAPIMisses/0.19.0-2                 1.43ms ± 2%        1.44ms ± 2%    ~     (p=0.321 n=9+8)
AlertsAPIHits/0.19.0-2                    930µs ± 7%         934µs ± 3%    ~     (p=0.247 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                         122µs ± 2%         130µs ± 4%  +6.72%  (p=0.000 n=10+10)
DedupAutocomplete/Run-2                  56.5µs ± 0%        60.7µs ± 1%  +7.51%  (p=0.000 n=9+10)
DedupColors/Run-2                        16.0µs ± 0%        16.9µs ± 1%  +5.72%  (p=0.000 n=8+10)

name                               old %/compression  new %/compression  delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             0.04 ± 0%          0.04 ± 0%    ~     (all equal)

name                               old B/alloc        new B/alloc        delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                            4.58M ± 0%         4.59M ± 0%  +0.05%  (p=0.000 n=9+9)
Decompress/Run-2                          2.70M ± 0%         2.70M ± 0%  +0.16%  (p=0.019 n=10+10)
CompressionAndDecompression/Run-2         4.59M ± 0%         4.59M ± 0%  +0.08%  (p=0.000 n=7+9)
PullAlerts/0.19.0-2                       2.65M ± 0%         2.65M ± 0%  +0.12%  (p=0.000 n=9+8)
AlertsAPIMisses/0.19.0-2                  3.03M ± 0%         3.03M ± 0%  +0.16%  (p=0.000 n=9+9)
AlertsAPIHits/0.19.0-2                    2.99M ± 0%         2.99M ± 0%  +0.15%  (p=0.000 n=9+9)

name                               old alloc/op       new alloc/op       delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                           1.13MB ± 0%        1.13MB ± 0%    ~     (p=0.305 n=10+10)
Decompress/Run-2                         4.24MB ± 0%        4.24MB ± 0%    ~     (p=1.000 n=10+10)
CompressionAndDecompression/Run-2        5.38MB ± 0%        5.38MB ± 0%    ~     (all equal)
PullAlerts/0.19.0-2                      1.28MB ± 0%        1.28MB ± 0%    ~     (p=1.000 n=10+10)
AlertsAPIMisses/0.19.0-2                 1.29MB ± 0%        1.29MB ± 0%    ~     (p=0.684 n=10+10)
AlertsAPIHits/0.19.0-2                    318kB ± 1%         318kB ± 1%    ~     (p=0.739 n=10+10)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                        73.7kB ± 0%        73.7kB ± 0%    ~     (p=0.420 n=9+8)
DedupAutocomplete/Run-2                  27.2kB ± 0%        27.2kB ± 0%    ~     (p=0.462 n=10+10)
DedupColors/Run-2                        7.36kB ± 0%        7.36kB ± 0%    ~     (p=0.211 n=10+10)

name                               old allocs/op      new allocs/op      delta
pkg:github.com/prymitive/karma/cmd/karma goos:linux goarch:amd64
Compress/Run-2                             32.5 ± 2%          32.3 ± 2%    ~     (p=0.650 n=10+10)
Decompress/Run-2                           80.0 ± 0%          80.0 ± 0%    ~     (all equal)
CompressionAndDecompression/Run-2           114 ± 0%           114 ± 0%    ~     (all equal)
PullAlerts/0.19.0-2                       22.6k ± 0%         22.6k ± 0%    ~     (all equal)
AlertsAPIMisses/0.19.0-2                  6.11k ± 0%         6.11k ± 0%    ~     (p=0.211 n=10+10)
AlertsAPIHits/0.19.0-2                    2.36k ± 0%         2.36k ± 0%    ~     (all equal)
pkg:github.com/prymitive/karma/internal/alertmanager goos:linux goarch:amd64
DedupAlerts/Run-2                           415 ± 0%           415 ± 0%    ~     (all equal)
DedupAutocomplete/Run-2                     114 ± 0%           114 ± 0%    ~     (all equal)
DedupColors/Run-2                          35.0 ± 0%          35.0 ± 0%    ~     (all equal)

@prymitive prymitive merged commit 20138a6 into master Oct 30, 2020
@prymitive prymitive deleted the test-coverage branch October 30, 2020 18:09
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant