karma: add ability to configure log format #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a rudimentary switch which would let users switch between different formats used for logging. This is needed so that software such as `logstash` could easily understand the structure of log messages and index them accordingly.
prymitive
approved these changes
May 27, 2019
|
Thanks! |
|
Sec, let me fix the tests 😄 |
Add a new field to the configuration string: log.format. It was missing thus the unit test fails.
|
👍there's a backlog of CI jobs since I just back from holidays, so it might take a while for everything to complete, I'll take a look and merge this in a few hours. Thanks again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a rudimentary switch which would let users switch between different
formats used for logging. This is needed so that software such as
logstashcould easily understand the structure of log messages andindex them accordingly.
Testing:
And got the expected results.
Also, the updated unit tests pass.