Skip to content

Commit

Permalink
fix(adding_version): Adding version cli
Browse files Browse the repository at this point in the history
* implement --version option

* Adding pre-commit

Precommit-Verified: 085dd93e0eb77c2c63f01c8bcaaec0ff3bcffda6f7f58bf5f8e0c17d45fb3185

Co-authored-by: Daniel Pryor <daniel@pryorda.net>
  • Loading branch information
finkr and pryorda authored Aug 19, 2021
1 parent fe17754 commit f83b058
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/unit/test_vmware_exporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -1721,3 +1721,11 @@ def test_valid_loglevel_cli_argument():
def test_main():
with pytest.raises(SystemExit):
main(['-h', '-l debug'])


def test_version(capsys):
with pytest.raises(SystemExit):
main(['-v'])
captured = capsys.readouterr()
assert captured.out.startswith("vmware_exporter")
assert captured.err == ""
5 changes: 5 additions & 0 deletions vmware_exporter/vmware_exporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@
from .helpers import batch_fetch_properties, get_bool_env
from .defer import parallelize, run_once_property

from .__init__ import __version__


class VmwareCollector():

Expand Down Expand Up @@ -2037,6 +2039,9 @@ def main(argv=None):
default=9272, help="HTTP port to expose metrics")
parser.add_argument('-l', '--loglevel', dest='loglevel',
default="INFO", help="Set application loglevel INFO, DEBUG")
parser.add_argument('-v', '--version', action="version",
version='vmware_exporter {version}'.format(version=__version__),
help='Print version and exit')

args = parser.parse_args(argv or sys.argv[1:])

Expand Down

0 comments on commit f83b058

Please sign in to comment.