Upgrading Docusaurus from 2.0.0-beta.4 → 2.4.1 + required fixes #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
May 26, 2023
| const { siteConfig = {} } = useDocusaurusContext(); | ||
| const isBrowser = useIsBrowser(); | ||
| const { baseUrl } = siteConfig; | ||
| const initAlgolia = (searchDocs, searchIndex, DocSearch) => { |
There was a problem hiding this comment.
seems like several references to algolia but seems to be completely replaced by lunr
There was a problem hiding this comment.
it looks like the creator of the lunr-search plugin forked the algolia search implementation (see the note on their readme here). So it might be possible to fully remove references to algolia from the swizzled component, but IMO that seems like a low-pri optimization (would require testing, could introduce maintenance friction as we'd be deviating from the canonical package, etc).
james-prysm
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
lastVerifiedBy/lastVerifiedDatefrom our header badges to align with broader Offchain docsets patterns2.0.0-beta.4→2.4.1RequestUpdateWidgetboilerplate repetition by swizzling theDocItemcomponent (60x -> 1x)TODOs:
.node-versionoverride isn't working) - clearing deploy cache may fix ✅PREVIEW: link
BROKEN BUILD FIX LOG:
NODE_VERSIONenv variable to netlify deploy config w/ value20node_moduleslocally, deletedpackage-lock.json,npm i, verified "works on my machine"package-lock.json, which fixed it