Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalized Deposit Trie Is Cached Incorrectly #10120

Closed
nisdas opened this issue Jan 24, 2022 · 0 comments · Fixed by #10511 or #10517
Closed

Finalized Deposit Trie Is Cached Incorrectly #10120

nisdas opened this issue Jan 24, 2022 · 0 comments · Fixed by #10511 or #10517
Assignees
Labels
Bug Something isn't working Help Wanted Extra attention is needed Priority: Medium Medium priority item

Comments

@nisdas
Copy link
Member

nisdas commented Jan 24, 2022

🐞 Bug Report

Description

Currently the proposer falls back to rebuilding the whole finalized deposit trie if we do have an invalid root for it. This was introduced in #8869 . The fallback was a workaround to the possibility that our cached trie had some inconsistent insertions leading to an invalid root. It was decided that falling back is better than potentially producing a block with an invalid deposit root and any resulting proofs from it. However as this comment #8869 (comment) alludes to, if the deposit trie takes too long to rebuild this can lead to block proposals being missed completely. The possibility that a block proposal can be missed from hitting this edge case is a good enough reason to ensure that the root cause for the bug is found and fixed. This issue is to track the core bug and the eventual resolution for it.

Has this worked before in a previous version?

No

🔬 Minimal Reproduction

This is hard to reproduce and has only come up in rare occasions.

🔥 Error

Cached deposit trie is invalid, rebuilding it now

What version of Prysm are you running? (Which release)

v2.0.5 and before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Help Wanted Extra attention is needed Priority: Medium Medium priority item
Projects
None yet
2 participants