Fallback For Deposit Trie Creation #8869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8869 +/- ##
===========================================
- Coverage 60.71% 60.40% -0.32%
===========================================
Files 527 527
Lines 37086 37376 +290
===========================================
+ Hits 22518 22577 +59
- Misses 11345 11565 +220
- Partials 3223 3234 +11 |
rkapka
reviewed
May 7, 2021
| valid, err := vs.validateDepositTrie(depositTrie, canonicalEth1Data) | ||
| // Log an error here, as even with rebuilding the trie, it is still invalid. | ||
| if !valid { | ||
| log.Errorf("Rebuilt deposit trie is invalid: %v", err) |
There was a problem hiding this comment.
Shouldn't err be returned from the function instead of just logging? We essentially have a problem with generating the deposit trie.
There was a problem hiding this comment.
The purpose is to log more strongly here, even if we fail creating a valid deposit trie we can still propose a block( as long as there are no deposits)
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
approved these changes
May 8, 2021
|
How long does a rebuild of the deposit trie take in mainnet? Proposal contexts are given a short TTL, if this routine takes more than a full slot then it may fail entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review