Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast Newly Added Blocks #389

Closed
nisdas opened this issue Aug 8, 2018 · 3 comments
Closed

Broadcast Newly Added Blocks #389

nisdas opened this issue Aug 8, 2018 · 3 comments
Labels
Blocked Blocked by research or external factors
Milestone
Ruby - v0.1

Comments

@nisdas
Copy link
Member

nisdas commented Aug 8, 2018 •
edited
Loading

Currently nodes do no broadcast any new blocks after they have been proposed or attested to, they just listen to the p2p feed for any newly processed blocks for syncing. A PR for this will allow proposers to broadcast their newly created blocks. Once this is done nodes will be able to both send and receive blocks instead of currently where they just receive blocks.
@nisdas nisdas added this to the Ruby milestone Aug 8, 2018
@nisdas nisdas changed the title Broadcast newly added blocks Broadcast Newly Added Blocks Aug 8, 2018
@terencechain terencechain self-assigned this Aug 8, 2018
@terencechain
Copy link
Member

terencechain commented Aug 8, 2018 •
edited
Loading

Why do we need fork choice rule for this? A proposer should broadcast its newly created block after he has been selected. The validator should apply fork choice rule on the newly received block from proposer

@nisdas
Copy link
Member Author

nisdas commented Aug 8, 2018

Ah, k yeah you are right. For some reason I mixed up saving the blocks with broadcasting them, changed the issue description.

@terencechain terencechain removed their assignment Aug 18, 2018
@nisdas nisdas assigned nisdas and unassigned nisdas Aug 20, 2018
@nisdas nisdas added the Blocked Blocked by research or external factors label Aug 21, 2018
@rauljordan
Copy link
Contributor

Completed by #1830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocked Blocked by research or external factors
Projects
None yet
Milestone
Ruby - v0.1
Development

No branches or pull requests
4 participants
@rauljordan @prestonvanloon @terencechain @nisdas