Fixing Sync #1830
Merged
Fixing Sync #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
==========================================
- Coverage 71.69% 71.35% -0.35%
==========================================
Files 104 104
Lines 7341 7372 +31
==========================================
- Hits 5263 5260 -3
- Misses 1590 1621 +31
- Partials 488 491 +3 |
rauljordan
approved these changes
Mar 3, 2019
terencechain
reviewed
Mar 3, 2019
| @@ -165,7 +165,7 @@ var defaultBeaconConfig = &BeaconChainConfig{ | |||
| DepositsForChainStart: 16384, | |||
| RandBytes: 3, | |||
| SyncPollingInterval: 6 * 1, // Query nodes over the network every slot for sync status. | |||
| BatchBlockLimit: 100, | |||
| BatchBlockLimit: 50, | |||
There was a problem hiding this comment.
This was just a param I was testing with to get sync to work. We can change it back
| @@ -62,6 +62,7 @@ func NewSyncService(ctx context.Context, cfg *Config) *Service { | |||
|
|
|||
| // Start kicks off the sync service | |||
| func (ss *Service) Start() { | |||
| slog.Info("Starting Sync Service") | |||
There was a problem hiding this comment.
We can just log Starting service here, sync is redundant with field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write why you are making the changes in this pull request.
Sync stalls at runtime, this PR is to fix any bugs for it.
Write a summary of the changes you are making.