Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV in onAttestation() method #5427

Closed
farazdagi opened this issue Apr 14, 2020 · 1 comment · Fixed by #5457
Closed

SIGSEGV in onAttestation() method #5427

farazdagi opened this issue Apr 14, 2020 · 1 comment · Fixed by #5457
Assignees
Labels
Bug Something isn't working Help Wanted Extra attention is needed

Comments

@farazdagi
Copy link
Contributor

From time to time, I see this nil pointer dereference issue:

[2020-04-14 12:14:59]  INFO sync: Requesting parent block currentSlot=686768 parentRoot=bdb62d670fbd
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x4d31c18]

goroutine 273 [running]:
github.com/prysmaticlabs/prysm/beacon-chain/blockchain.(*Service).onAttestation(0xc00000c3c0, 0x569b300, 0xc04245e000, 0xc03db25f20, 0x0, 0x0, 0x0, 0x0, 0x0)
        beacon-chain/blockchain/process_attestation.go:129 +0x538
github.com/prysmaticlabs/prysm/beacon-chain/blockchain.(*Service).ReceiveAttestationNoPubsub(0xc00000c3c0, 0x569b300, 0xc04242bfb0, 0xc03db25f20, 0x0, 0x0)
        beacon-chain/blockchain/receive_attestation.go:36 +0xee
github.com/prysmaticlabs/prysm/beacon-chain/blockchain.(*Service).processAttestation(0xc00000c3c0, 0xc00eb4f740)
        beacon-chain/blockchain/receive_attestation.go:113 +0x543
created by github.com/prysmaticlabs/prysm/beacon-chain/blockchain.(*Service).Start
        beacon-chain/blockchain/service.go:233 +0xac5
@prestonvanloon prestonvanloon added the Bug Something isn't working label Apr 14, 2020
@prestonvanloon
Copy link
Member

Need nil checks here

s.forkChoiceStore.ProcessAttestation(ctx, indexedAtt.AttestingIndices, bytesutil.ToBytes32(a.Data.BeaconBlockRoot), a.Data.Target.Epoch)

@prestonvanloon prestonvanloon added the Help Wanted Extra attention is needed label Apr 14, 2020
@farazdagi farazdagi self-assigned this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants