-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PARTIALLY_DEPOSITED status #7071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhly
changed the title
Add PARTIALLY_DEPOSITED status
[WIP] Add PARTIALLY_DEPOSITED status
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #7071 +/- ##
==========================================
+ Coverage 61.94% 62.25% +0.31%
==========================================
Files 408 406 -2
Lines 32850 31615 -1235
==========================================
- Hits 20350 19683 -667
+ Misses 9632 9137 -495
+ Partials 2868 2795 -73 |
michaelhly
changed the title
[WIP] Add PARTIALLY_DEPOSITED status
Add PARTIALLY_DEPOSITED status
Aug 23, 2020
rauljordan
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Return
PARTIALLY_DEPOSITED
when validator's effective balance is less than 32 eth.Which issues(s) does this PR fix?
Fixes #6063