Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PARTIALLY_DEPOSITED status #7071

Merged
merged 15 commits into from
Aug 27, 2020
Merged

Conversation

michaelhly
Copy link
Contributor

@michaelhly michaelhly commented Aug 20, 2020

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?
Return PARTIALLY_DEPOSITED when validator's effective balance is less than 32 eth.

Which issues(s) does this PR fix?
Fixes #6063

@michaelhly michaelhly requested a review from a team as a code owner August 20, 2020 21:31
@michaelhly michaelhly changed the title Add PARTIALLY_DEPOSITED status [WIP] Add PARTIALLY_DEPOSITED status Aug 20, 2020
@michaelhly michaelhly marked this pull request as draft August 20, 2020 21:31
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #7071 into master will increase coverage by 0.31%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master    #7071      +/-   ##
==========================================
+ Coverage   61.94%   62.25%   +0.31%     
==========================================
  Files         408      406       -2     
  Lines       32850    31615    -1235     
==========================================
- Hits        20350    19683     -667     
+ Misses       9632     9137     -495     
+ Partials     2868     2795      -73     

@michaelhly michaelhly changed the title [WIP] Add PARTIALLY_DEPOSITED status Add PARTIALLY_DEPOSITED status Aug 23, 2020
@michaelhly michaelhly marked this pull request as ready for review August 23, 2020 16:09
@rauljordan rauljordan merged commit b98b9b7 into prysmaticlabs:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending validator count reflects partially deposited validators
2 participants