Revert "Update fastssz" #7100
Merged
Revert "Update fastssz" #7100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78a25f9.
rauljordan
approved these changes
Aug 24, 2020
terencechain
added a commit
that referenced
this pull request
Aug 25, 2020
This reverts commit b954db9.
2 tasks
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Aug 27, 2020
* Revert "Revert "Update fastssz" (#7100)" This reverts commit b954db9. * Preston's patch * Merge branch 'master' of github.com:prysmaticlabs/prysm into revert-7100-revert-6760-update-fssz * Update fssz, add regression test case * more HTR with fssz * fix some tests * only one test left * Make it so that HTR will work * gofmt, imports * gofmt, imports * fix * Merge branch 'master' of github.com:prysmaticlabs/prysm into revert-7100-revert-6760-update-fssz * fix * Merge branch 'master' into revert-7100-revert-6760-update-fssz * Merge refs/heads/master into revert-7100-revert-6760-update-fssz * gaz * Merge branch 'revert-7100-revert-6760-update-fssz' of github.com:prysmaticlabs/prysm into revert-7100-revert-6760-update-fssz * Merge refs/heads/master into revert-7100-revert-6760-update-fssz * fix test * Merge branch 'revert-7100-revert-6760-update-fssz' of github.com:prysmaticlabs/prysm into revert-7100-revert-6760-update-fssz * Merge refs/heads/master into revert-7100-revert-6760-update-fssz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6760
My proposers were failing to propose blocks:
I walked through the recent comments and found this to be the potential offender. I reverted this for run time and verified proposing blocks has indeed worked without this PR. Reverting this while spending time to debug what is wrong