Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastssz: Attempt 2 #7115

Merged
merged 21 commits into from
Aug 27, 2020
Merged

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Aug 26, 2020

Reverts #7100.

See #6760 for original description.

This also replaces many uses of stateutil.XXXRoot.
There is also a regression test added to ensure the proposal bug is fixed.

Local tests

@prestonvanloon prestonvanloon changed the title Revert "Revert "Update fastssz"" Update fastssz: Attempt 2 Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5bfc457). Click here to learn what that means.
The diff coverage is 77.57%.

@@            Coverage Diff            @@
##             master    #7115   +/-   ##
=========================================
  Coverage          ?   61.71%           
=========================================
  Files             ?      408           
  Lines             ?    32147           
  Branches          ?        0           
=========================================
  Hits              ?    19841           
  Misses            ?     9485           
  Partials          ?     2821           

@prestonvanloon prestonvanloon marked this pull request as ready for review August 27, 2020 15:04
@prestonvanloon prestonvanloon requested a review from a team as a code owner August 27, 2020 15:04
terencechain
terencechain previously approved these changes Aug 27, 2020
rauljordan
rauljordan previously approved these changes Aug 27, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit b7175b3 into master Aug 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert-7100-revert-6760-update-fssz branch August 27, 2020 18:13
@farazdagi farazdagi mentioned this pull request Oct 1, 2020
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants