Update rpc validator exit tests #7122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Aug 27, 2020
rkapka
commented
Aug 27, 2020
rkapka
commented
Aug 27, 2020
This reverts commit 0da06d5.
|
Blocked by #7115 |
# Conflicts: # beacon-chain/rpc/validator/exit.go # deps.bzl # go.mod # go.sum
rkapka
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7122 +/- ##
==========================================
- Coverage 61.71% 61.70% -0.02%
==========================================
Files 406 406
Lines 32216 32142 -74
==========================================
- Hits 19883 19834 -49
+ Misses 9512 9490 -22
+ Partials 2821 2818 -3 |
rauljordan
approved these changes
Aug 28, 2020
michaelhly
pushed a commit
to michaelhly/prysm
that referenced
this pull request
Aug 28, 2020
* Create mocks for updated ethereumapis * Revert "Create mocks for updated ethereumapis" This reverts commit 0da06d5. * update ethereumapis * change root calculation * fix test assertion * fix test assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR updates the
ethereumapisdependency and related mocks.Which issues(s) does this PR fix?
N/A
Other notes for review
I commented out accounts-v2 code from
update-mockgen.shbecause it causes error when running the script. I will open an issue for this problem.