Move attestation's source checkpoint validation to VerifyAttestationNoVerifySignature #8598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Mar 12, 2021
| @@ -105,41 +105,52 @@ func VerifyAttestationNoVerifySignature( | |||
| ctx context.Context, | |||
| beaconState iface.BeaconState, | |||
| att *ethpb.Attestation, | |||
| ) (iface.BeaconState, error) { | |||
| ) error { | |||
There was a problem hiding this comment.
if you arent returning anything, please change the input to a read only state.
Codecov Report
@@ Coverage Diff @@
## develop #8598 +/- ##
===========================================
- Coverage 61.40% 61.32% -0.08%
===========================================
Files 484 483 -1
Lines 34205 34151 -54
===========================================
- Hits 21004 20944 -60
- Misses 10096 10108 +12
+ Partials 3105 3099 -6 |
terencechain
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The purpose of #8566 was to enable attestation validation without needing to modify the state. The refactor did not move source checkpoint validation from
ProcessAttestationNoVerifySignaturetoVerifyAttestationNoVerifySignature, which this PR corrects.I also removed the beacon state return value from
ProcessAttestationNoVerifySignaturebecause it does not modify the state in any way.Which issues(s) does this PR fix?
N/A
Other notes for review
N/A