Refactor ProcessAttestationNoVerifySignature
to VerifyAttestationNoVerifySignature
#8566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Currently
In Prysm, we use
ProcessAttestationNoVerifySignature
as a pure verification function without the advertised side effect as modifying beacon state. This PR changes:Note that
Verify attestation valid indices
now comes beforeModify beacon state with attestation
. That is ok and arguably betterWhich issues(s) does this PR fix?
Helps #8563
Other notes for review
#8563 is blocked until this