Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E refactoring: BeaconNode and BeaconNodeSet #8667

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other / Refactoring

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Extracted from #8643

Other notes for review

@farazdagi farazdagi self-assigned this Mar 25, 2021
@farazdagi farazdagi requested a review from a team as a code owner March 25, 2021 11:49
@farazdagi farazdagi mentioned this pull request Mar 25, 2021
6 tasks
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #8667 (ec60bdd) into develop (e56ab29) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8667      +/-   ##
===========================================
+ Coverage    61.19%   61.25%   +0.05%     
===========================================
  Files          494      494              
  Lines        34343    34343              
===========================================
+ Hits         21017    21036      +19     
+ Misses       10189    10162      -27     
- Partials      3137     3145       +8     

@farazdagi farazdagi marked this pull request as draft March 25, 2021 12:19
@farazdagi farazdagi marked this pull request as ready for review March 25, 2021 12:19
@farazdagi farazdagi merged commit 6a4d4d7 into develop Mar 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the e2e-refactoring-beacon branch March 25, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants