Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E refactoring #8643

Merged
merged 47 commits into from
Mar 26, 2021
Merged

E2E refactoring #8643

merged 47 commits into from
Mar 26, 2021

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Mar 23, 2021

What type of PR is this?

Other / Refacotring

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

N/A

Other notes for review

  • Once this PR merges, we will have correct node process management (with proper cleanup after each test), so it will be possible to merge e2e connectivity fix (in Add connectivity E2E test #8607, which is done, but since running multiple tests on a single shard was impossible, that PR fails e2e test, the problem will not exist after refactored test runner is used)
  • It is probably easier to review the PR by checking it in, and reviewing endtoend_test.go file locally.

@farazdagi farazdagi self-assigned this Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #8643 (20c49cb) into develop (e32c88e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 20c49cb differs from pull request most recent head 46d7af8. Consider uploading reports for the commit 46d7af8 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8643      +/-   ##
===========================================
- Coverage    61.24%   61.22%   -0.03%     
===========================================
  Files          494      494              
  Lines        34343    34343              
===========================================
- Hits         21035    21028       -7     
- Misses       10171    10178       +7     
  Partials      3137     3137              

@farazdagi farazdagi marked this pull request as ready for review March 26, 2021 01:42
@farazdagi farazdagi requested a review from a team as a code owner March 26, 2021 01:42
@rauljordan rauljordan merged commit 961a012 into develop Mar 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the e2e-refactoring branch March 26, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants