Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E refactoring: SlasherNodeSet and SlasherNode #8672

Merged
merged 3 commits into from
Mar 26, 2021
Merged

E2E refactoring: SlasherNodeSet and SlasherNode #8672

merged 3 commits into from
Mar 26, 2021

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Mar 25, 2021 •
edited
Loading

What type of PR is this?

Other / Refactoring

What does this PR do? Why is it needed?

  • Follow up to E2E refactoring: bootnode #8659 (see it for implementation details)
  • In this PR:
    • Adds SlasherNode and SlasherNodeSet, and corresponding ComponentRunner methods (similar to validator and beacon nodes, we need to start processes individually or in bunches, see E2E refactoring: ValidatorNode and ValidatorNodes #8665 for details).
    • Additionally, per @rkapka request, for deduplication of code, process set rely on helper method to spawn and wait on processes (see helpers.go:WaitOnNodes(). Corresponding updates to ValidatorNodeSet and BeaconNodeSet are also added to this PR.

Which issues(s) does this PR fix?

Extracted from #8643

Other notes for review

@farazdagi farazdagi self-assigned this Mar 25, 2021
@farazdagi farazdagi mentioned this pull request Mar 25, 2021
Merged
6 tasks
@farazdagi farazdagi marked this pull request as ready for review March 25, 2021 20:12
@farazdagi farazdagi requested a review from a team as a code owner March 25, 2021 20:12
@prylabs-bulldozer prylabs-bulldozer bot merged commit 1390175 into develop Mar 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the e2e-refactoring-slasher-node branch March 26, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@farazdagi farazdagi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farazdagi @rauljordan