Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connectivity E2E test #8607

Merged
merged 62 commits into from
Mar 27, 2021
Merged

Add connectivity E2E test #8607

merged 62 commits into from
Mar 27, 2021

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Mar 15, 2021

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Occasionally, e2e tests fail with msg="Failed to find peers" error="context deadline exceeded" prefix=p2p, this PR introduces the minimal test to reproduce and fix the issue.

Which issues(s) does this PR fix?

N/A

Other notes for review

  • ❗ Review after E2E refactoring #8643 is merged (as it requires functionality of that PR, and is based on it -- so until that PR is merged, delta is misleading)

@farazdagi farazdagi self-assigned this Mar 15, 2021
@farazdagi farazdagi mentioned this pull request Mar 26, 2021
6 tasks
@farazdagi farazdagi marked this pull request as ready for review March 26, 2021 02:02
@farazdagi farazdagi requested a review from a team as a code owner March 26, 2021 02:02
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #8607 (ed3afbc) into develop (5f2f53a) will increase coverage by 0.07%.
The diff coverage is 77.77%.

❗ Current head ed3afbc differs from pull request most recent head 4df6d11. Consider uploading reports for the commit 4df6d11 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8607      +/-   ##
===========================================
+ Coverage    61.18%   61.25%   +0.07%     
===========================================
  Files          494      494              
  Lines        34363    34359       -4     
===========================================
+ Hits         21024    21048      +24     
+ Misses       10195    10173      -22     
+ Partials      3144     3138       -6     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 54cf5f3 into develop Mar 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-e2e-no-peers-issue branch March 27, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants