Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing block proposal due to StateBySlot() / StateByRoot() #9612

Closed
Tracked by #9708
jmozah opened this issue Sep 16, 2021 · 1 comment
Closed
Tracked by #9708

Missing block proposal due to StateBySlot() / StateByRoot() #9612

jmozah opened this issue Sep 16, 2021 · 1 comment

Comments

@jmozah
Copy link
Contributor

jmozah commented Sep 16, 2021

💎 Issue

Background

As part of debug session for the GetBlock() optimisation, this issue was found and needs to be looked in to.

Description

stategen->StateBySlot() / StateByRoot()

  • This was observed few times that the loadStateByRoot() takes several seconds and the proposal will be lost. Bolt might be the culpreit here as it might take time to get state that is not in hoStateCache or the epochCache. The second major time saving in this track is this fix.
@jmozah jmozah added the Tracking Gotta Catch 'Em All label Sep 16, 2021
@jmozah jmozah mentioned this issue Sep 16, 2021
Merged
@jmozah jmozah mentioned this issue Sep 30, 2021
Closed
6 tasks
@jmozah jmozah removed the Tracking Gotta Catch 'Em All label Sep 30, 2021
@terencechain
Copy link
Member

Let's refer to #9708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmozah @terencechain