Web3Signer: Object Mapper and Types #10061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Enhancement
23 tasks
james-prysm
commented
Jan 11, 2022
| - Files Added: | ||
| - validator/keymanager/remote-web3signer package | ||
|
|
||
| - Files Modified: |
There was a problem hiding this comment.
this is actually part of the cli pr so please ignore this section, it was just to keep track of file changes as we might want to refactor this in the future
rauljordan
reviewed
Jan 11, 2022
| Deposits: make([]*Deposit, len(body.Deposits)), | ||
| VoluntaryExits: make([]*SignedVoluntaryExit, len(body.VoluntaryExits)), | ||
| SyncAggregate: &SyncAggregate{ | ||
| SyncCommitteeBits: hexutil.Encode(body.SyncAggregate.SyncCommitteeBits), |
There was a problem hiding this comment.
I think SyncCommitteeBits being a special type, (Bitvector), not sure if the hexutil will directly represent it as we need. You might want to call the .Bytes() method of bitvectors and bitlists https://github.com/prysmaticlabs/go-bitfield/blob/385d8c5e3fb7f24c83e25f32dd9511f5462ea0b8/bitvector512.go#L73 before doing hexutil.Encode
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
rauljordan
reviewed
Jan 11, 2022
rauljordan
previously approved these changes
Jan 11, 2022
rauljordan
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Part of #9994
What does this PR do? Why is it needed?
This adds the JSON object types for web3signer and the object mapper functions to map from Prysm Datatypes to Web3signer datatypes