Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Not Copy State During Upgrade #10102

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Do Not Copy State During Upgrade #10102

merged 5 commits into from
Jan 20, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jan 20, 2022

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • In both of our fork upgrade paths we copy the state during the upgrade. This is redundant as the state that we are copying is only instantiated in that function itself.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner January 20, 2022 02:07
@nisdas nisdas requested review from kasey, potuz and uncdr January 20, 2022 02:07
@prylabs-bulldozer prylabs-bulldozer bot merged commit af06bb9 into develop Jan 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the noCopy branch January 20, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@uncdr uncdr Awaiting requested review from uncdr uncdr is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @terencechain