-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path to Keystore #10152
Add path to Keystore #10152
Conversation
Thanks for the feedback @rkapka. I addressed so this PR is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you need to run the gazelle prefix "github.com/prysmaticlabs/prysm/validator/keymanager" command in the validators keymanager folder to fix the linter, must be from added dependencies for test. thanks for the contribution LGTM after that.
Thanks for the tip @james-prysm ! On a slightly related note, Line 1 in 4b3a723
Should I open a new issue to track upgrading to bazel |
let me double check with the team I'm sure they know about bazel 5.0.0 but might not be ready to upgrade yet ( assumption) i'd hold off on it. happy to continue the conversation on discord if interested. |
Sounds good, I'll hold off on creating a GH issue. |
This PR should definitely not update Bazel. |
will test out UI with this change so see backwards compatability before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR after testing out the following
- backup account returns a keystore with path property
- import keystore with new path property still works
- import keystore without new path property still works
- backup keystore without new path property returns a keystore with path property
Agreed. My intention was to create a separate GH issue to track upgrading to Bazel 5.0.0 but defer to you / the rest of the maintainers on how best to track that effort. Thanks for reviewing and merging! Keep up the great work on Prysm. |
What type of PR is this?
What does this PR do? Why is it needed?
Adds
path
to theKeystore
struct because it is a required JSON field per EIP-2335Which issues(s) does this PR fix?
Fixes #10107