Refactor Core/Types Package to Align With Spec #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, then fix node, then done
…nto single-state-refactor
…nto single-state-refactor
…nto single-state-refactor
…ocessed vs aggregated ones
terencechain
reviewed
Dec 1, 2018
beacon-chain/core/types/state.go
Outdated
| @@ -277,6 +284,14 @@ func (b *BeaconState) PenalizedETH(period uint64) uint64 { | |||
| return totalPenalty | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
you have merge conflict here
terencechain
reviewed
Dec 2, 2018
| @@ -11,36 +10,34 @@ message BeaconState { | |||
| repeated CrosslinkRecord crosslinks = 3; | |||
There was a problem hiding this comment.
Can you please add sectional comments like this for BeaconState? It makes crosschecking the fields easier : )
|
Closing in favor of doing this in smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #781.
Description
This PR refactors all the type protos and the inner core/types package to align with all the spec changes as part of our refactoring effort.