Refactor fork data #1028
Merged
Refactor fork data #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## update-beacon-state-proto #1028 +/- ##
=============================================================
+ Coverage 72.05% 72.14% +0.08%
=============================================================
Files 75 75
Lines 4595 4588 -7
=============================================================
- Hits 3311 3310 -1
+ Misses 967 961 -6
Partials 317 317 |
Codecov Report
@@ Coverage Diff @@
## update-beacon-state-proto #1028 +/- ##
==========================================================
Coverage 72.05% 72.05%
==========================================================
Files 75 75
Lines 4595 4595
==========================================================
Hits 3311 3311
Misses 967 967
Partials 317 317 |
rauljordan
approved these changes
Dec 2, 2018
terencechain
approved these changes
Dec 2, 2018
prestonvanloon
changed the base branch from
update-beacon-state-proto
to
master
|
This is part of #781. |
KimiWu123
pushed a commit
to KimiWu123/prysm
that referenced
this pull request
Dec 15, 2018
* update beacon-state proto to new spec * AttestationData * use bazel's pb.go * boundry -> boundary * Refactor fork data * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: It appears that the fork data was never set in the first place.
I fully expected some tests to break, but it looks like a gap in coverage to determine the fork version.
Probably because is not fully used yet.
Do we have a tracking issue to set fork data?
#258 should include changes for fork data here.