Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up BeaconBlock's Validator Fields #1037

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Clean Up BeaconBlock's Validator Fields #1037

merged 2 commits into from
Dec 4, 2018

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Dec 3, 2018 •
edited
Loading

Replace BeaconBlock's deprecated validators and validator_set_change_slot fields for validator_registry and validator_registry_latest_change_slot

This is part of #781.

@terencechain terencechain self-assigned this Dec 3, 2018
@codecov
Copy link

codecov bot commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #1037 into master will increase coverage by 0.21%.
The diff coverage is 79.77%.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
+ Coverage   71.84%   72.06%   +0.21%     
==========================================
  Files          75       75              
  Lines        4575     4575              
==========================================
+ Hits         3287     3297      +10     
+ Misses        969      961       -8     
+ Partials      319      317       -2

@prestonvanloon
Copy link
Member

Could you add a sentence or two to summarize your changes, please?

@terencechain
Copy link
Member Author

Could you add a sentence or two to summarize your changes, please?

Done

@terencechain terencechain merged commit b8a9e83 into master Dec 4, 2018
KimiWu123 pushed a commit to KimiWu123/prysm that referenced this pull request Dec 15, 2018
@terencechain @KimiWu123
clean up BeaconBlock's validator fields (prysmaticlabs#1037)
70a0fdd
@nisdas nisdas deleted the deprecate-block-validators branch January 28, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

Assignees

@terencechain terencechain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @prestonvanloon