Cleanup Discarded Connections Correctly #10574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Bug
rauljordan
approved these changes
Apr 28, 2022
prestonvanloon
pushed a commit
that referenced
this pull request
Apr 29, 2022
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> (cherry picked from commit 58ad800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
#10498 introduced some changes in our
powchainservice in order to adapt it for the merge. However a poll routine was introduced which did not cleanup discarded connections correctly. This PR fixes it here along with any other places where there was improper cleanup.Which issues(s) does this PR fix?
Fixes #10573
Other notes for review