Fix Doppelganger Check #10582
Merged
Fix Doppelganger Check #10582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Apr 29, 2022
prestonvanloon
approved these changes
Apr 29, 2022
prestonvanloon
pushed a commit
that referenced
this pull request
Apr 29, 2022
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com> (cherry picked from commit ad03938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In #9969 , we adapted out doppelganger check to altair. However, we introduced an off by 1 bug in the number of states to check. Due to how the doppelganger check works, we cannot perform the check for validator's that have attested in the previous 2 epochs.
This PR also changes how we fetch the previous state, instead preferring to fetch till the end of the epoch.
Which issues(s) does this PR fix?
N.A
Other notes for review