Insert over-the-wire slashing to forkchoice #10615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove_equivocating_validators
…ove_equivocating_validators
…ove_equivocating_validators
potuz
reviewed
May 4, 2022
beacon-chain/blockchain/new_slot.go
Outdated
| @@ -36,6 +36,10 @@ func (s *Service) NewSlot(ctx context.Context, slot types.Slot) error { | |||
| return errors.Wrap(err, "could not reset boosted proposer root in fork choice") | |||
| } | |||
|
|
|||
| // Insert slashings to forkchoice. | |||
| slashings := s.cfg.SlashingPool.PendingAttesterSlashings(ctx, s.head.state, true) | |||
| s.insertSlashingsToForkChoiceStore(ctx, slashings) | |||
There was a problem hiding this comment.
What worries me about this approach is that we will be going over the following loops on every slot:
- Check that each slashing has not been included on chain or not
- Send the slashings to forkchoice, which will be a noop (I will fix this now)
We shouldn' t be sending all slashings every single slot until the pending queue dissapears.
potuz
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we can insert over the wire slashing objects to forkchoice to account for equivocation in #10597