Unrealized justification #10659
Merged
Unrealized justification #10659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nrealized_justification
rkapka
requested changes
May 22, 2022
beacon-chain/core/epoch/precompute/justification_finalization.go
Outdated
Show resolved
Hide resolved
Co-authored-by: terencechain <terence@prysmaticlabs.com>
nisdas
reviewed
May 24, 2022
| return nil, err | ||
| } | ||
|
|
||
| if err := state.SetPreviousJustifiedCheckpoint(state.CurrentJustifiedCheckpoint()); err != nil { |
There was a problem hiding this comment.
this line makes me uncomfortable for some reason. The big change with how the spec does it might be why it feels that way. I know technically ComputeCheckpoints is stateless, but I have to think a lot more on if anything breaks with changing the ordering like this.
terencechain
approved these changes
May 27, 2022
rkapka
approved these changes
May 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the core changes to compute unrealized justification and finalization checkpoints.