Part 2 of Restructuring BeaconBlock Proto - Add BeaconBody #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
=======================================
Coverage 72.16% 72.16%
=======================================
Files 75 75
Lines 4591 4591
=======================================
Hits 3313 3313
Misses 961 961
Partials 317 317 |
rauljordan
approved these changes
Dec 10, 2018
| @@ -170,14 +170,23 @@ message BeaconBlock { | |||
| // repeated AttestationRecord attestations = 6; | |||
| // Specials consist of exist, penalities, etc. | |||
| repeated SpecialRecord specials = 7 [deprecated=true]; // Deprecated in favor of unify specials object w/ attestations. | |||
| repeated bytes proposer_signature = 8; // Type of [uint384]? | |||
|
|
|||
| repeated bytes signature = 8; // Type of [uint384]? | |||
There was a problem hiding this comment.
Did we define a uint384 type in proto in a separate file before? Can we use that
There was a problem hiding this comment.
We should. Similar to what we did with Uint32List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #781
This PR adds BeaconBody to Proto