Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various warnings #10710

Merged
merged 9 commits into from
May 19, 2022
Merged

Clean up various warnings #10710

merged 9 commits into from
May 19, 2022

Conversation

terencechain
Copy link
Member

Fixed:

  • Exported comments
  • Empty slice declarations
  • Redundant castings
  • Camel cases

@terencechain terencechain added the Cleanup Code health! label May 18, 2022
@terencechain terencechain self-assigned this May 18, 2022
@terencechain terencechain marked this pull request as ready for review May 18, 2022 01:18
@terencechain terencechain requested review from rkapka, nisdas and a team as code owners May 18, 2022 01:18
@terencechain terencechain requested a review from saolyn May 18, 2022 01:18
@terencechain terencechain force-pushed the cleanups branch 2 times, most recently from c7c6849 to f0f35a2 Compare May 18, 2022 02:53
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
@@ -78,7 +78,7 @@ func GenerateAttestations(
if err != nil {
return nil, err
}
headState = state.BeaconState(genState)
headState = genState
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see another headState = state.BeaconState(genState). Want to fix that as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 092e9e1 into develop May 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the cleanups branch May 19, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants