Implement generate-auth-secret on beacon node CLI #10733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
…into jwt-additions
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
rauljordan
reviewed
May 23, 2022
terencechain
added
the
docs-required
|
Hi @prestonvanloon we identified that doing complex validation on the integrity of the provided file path was too much work and not worth the time for this feature |
prestonvanloon
approved these changes
Jun 6, 2022
rauljordan
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
One outstanding UX challenge with our installation guidance is the process of establishing a secure connection between beacon node <> execution client. Our current guidance is insecure-by-default unless users go out of their way to generate random strings, which can be frustrating for nontechnical users (and even technical users).
This PR introduces a
generate-auth-secretcommand that improves the secure-by-default user experience and quickstart guidance.Criticality and risk
I perceive this as being a C0/C1 based on how important it is for our Merge quickstart.
I perceive this as being low-risk because the changes are isolated into a separate command.
Other notes for review
prysmrepo, and I have a lot to learn. So please don't hesitate to recommend significant changes that would help this PR align with the way you would implement this feature.