Fix withdrawal epoch overflows #10739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
May 23, 2022
| require.NoError(t, err, "Could not process registry updates") | ||
| return state, nil | ||
| func processRegistryUpdatesWrapper(_ *testing.T, state state.BeaconState) (state.BeaconState, error) { | ||
| return epoch.ProcessRegistryUpdates(context.Background(), state) |
There was a problem hiding this comment.
Spec test requires this test to fail. In this case, we don't want to error out, and we want to return the error to the caller and the caller can decide whether to pass or fail
rauljordan
previously approved these changes
May 23, 2022
rauljordan
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures withdrawal epoch doesn't overflow. Part of spec test updates to
v1.2.0-rc.1Please merge this before #10665