-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator client builder support #10749
Changes from all commits
fabd6f2
0973e08
0a834ef
ffb3ef2
e4dcbc4
81a6c3f
d1fc816
ca71dc0
e2aa4b1
253c773
fb8f064
4935b1d
8340c01
288f338
e566041
5205f9b
9d29280
50b4244
bd09469
3cfa2de
449d12d
1e7785e
4961971
73cdbb4
fdd8848
1a06daa
8c9b1f6
bdc2d81
9e16452
8e59afc
14c412e
e242eb0
37193be
a4981f0
399f216
b2ef039
b47fd56
6da4f35
e54dd78
5612b2f
e5792ea
174cacb
34e6dc2
eb9ef3b
dc49906
eb37daa
8e4499d
3e1b328
108c9c8
3c9ce71
50abab8
0721273
f9b6815
bb31852
d6df7b4
2382712
57bb6e6
35c4311
0b932fe
91efa80
e005b4a
ca02322
575408d
a89317f
5f4836c
fc5abb0
e6eed94
e1b9e43
a8b9937
db80ef1
2aba632
5867cf8
a93a8d7
a37f4cb
90a5f73
0c74cdd
a3b167b
eb841aa
4372811
5cd4d6a
1aec13a
2cd333f
6d634d5
e24f6db
74f1ed3
992f89f
c41ca76
4778b7c
c3699d9
263f5ac
60e36d6
baa79b9
701e09a
98962ee
178f441
3a2326d
e971034
49c07b1
3209082
2609a21
fc1b0b6
6b2630a
64f4a57
a8d1082
7e943a5
5c570e5
321d57e
b120c33
f33dfba
eb09781
82ba338
c2ef93d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ import ( | |
"runtime" | ||
"time" | ||
|
||
field_params "github.com/prysmaticlabs/prysm/config/fieldparams" | ||
"github.com/prysmaticlabs/prysm/config/params" | ||
"github.com/prysmaticlabs/prysm/io/file" | ||
"github.com/urfave/cli/v2" | ||
) | ||
|
@@ -327,21 +327,36 @@ var ( | |
// FeeRecipientConfigFileFlag defines the path or URL to a file with proposer config. | ||
FeeRecipientConfigFileFlag = &cli.StringFlag{ | ||
Name: "fee-recipient-config-file", | ||
Usage: "Set path to a JSON file containing validator mappings to ETH addresses for receiving transaction fees when proposing blocks (i.e. --fee-recipient-config-file=/path/to/proposer.json). File format found in docs", | ||
Usage: "DEPRECATED, please use proposer-settings-file", | ||
Value: "", | ||
} | ||
// FeeRecipientConfigURLFlag defines the path or URL to a file with proposer config. | ||
FeeRecipientConfigURLFlag = &cli.StringFlag{ | ||
Name: "fee-recipient-config-url", | ||
Usage: "Set URL to a REST endpoint containing validator mappings to ETH addresses for receiving transaction fees when proposing blocks (i.e. --fee-recipient-config-url=https://example.com/api/getConfig). File format found in docs", | ||
Usage: "DEPRECATED, please use proposer-settings-url", | ||
Value: "", | ||
} | ||
|
||
// ProposerSettingsFlag defines the path or URL to a file with proposer config. | ||
ProposerSettingsFlag = &cli.StringFlag{ | ||
Name: "proposer-settings-file", | ||
Usage: "Set path to a YAML or JSON file containing validator settings used when proposing blocks such as (fee recipient and gas limit) (i.e. --proposer-settings-file=/path/to/proposer.json). File format found in docs", | ||
Value: "", | ||
} | ||
// ProposerSettingsURLFlag defines the path or URL to a file with proposer config. | ||
ProposerSettingsURLFlag = &cli.StringFlag{ | ||
Name: "proposer-settings-url", | ||
Usage: "Set URL to a REST endpoint containing validator settings used when proposing blocks such as (fee recipient) (i.e. --proposer-settings-url=https://example.com/api/getConfig). File format found in docs", | ||
Value: "", | ||
} | ||
|
||
// SuggestedFeeRecipientFlag defines the address of the fee recipient. | ||
SuggestedFeeRecipientFlag = &cli.StringFlag{ | ||
Name: "suggested-fee-recipient", | ||
Usage: "Sets ALL validators' mapping to a suggested an eth address to receive gas fees when proposing a block. This is a fall back setting and will be overridden by other flags that update the proposer settings. ", | ||
Value: field_params.EthBurnAddressHex, | ||
Name: "suggested-fee-recipient", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we call this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it is only a suggestion because by the definitions of the APIs they don't "guarantee" that the execution client will use it 😓 was wording from Jim There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My main point was that I think the help text should be more user-centric; talking about which API calls this is used in isn't as helpful as explaining the big picture effect. I'm suggesting we should say something like " |
||
Usage: "Sets ALL validators' mapping to a suggested an eth address to receive gas fees when proposing a block." + | ||
" note that this is only a suggestion when integrating with a Builder API, which may choose to specify a different fee recipient as payment for the blocks it builds." + | ||
" For additional setting overrides use the --" + ProposerSettingsFlag.Name + " or --" + ProposerSettingsURLFlag.Name + " Flags. ", | ||
Value: params.BeaconConfig().EthBurnAddressHex, | ||
} | ||
) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per our conversation on fieldparams vs BeaconConfig etc, we talked about the gas limit being in BeaconConfig because it is likely to vary per-chain, but EthBurnAddress seems different because we probably want to use the same EthBurnAddress everywhere, right? So maybe we can just yeet this over to a package-level constant, maybe in the
blockchain
package (because that's where a bunch of the execution engine code lives).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this as well but heard that there could be other addresses as the burn address ( not sure if totally correct). open to do either or.