Do not fill in blocks that are not in the finalized branch #10776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
added
Bug
terencechain
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
fillInForkChoiceMissingBlocks(ctx, blk, finalizedChkpt, justifiedChkpt)obtains from DB all blocks starting from the parent ofblkand goes up the parent chain. It inserts all blocks with slots higher than the last finalized checkpoint plus the parent of the last such slot.This function does not check that this last parent is the finalized block, if it isn't then the function inserts a contending chain to the finalized block and it should be declared invalid.
In addition, this function has an off-by-one in which it passes also the finalized block to forkchoice, all tests for this functions were wrongfully counting nodes adding the extra finalized checkpoint that should not have been saved.