Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator client: add submit registration #10785

Merged
merged 12 commits into from
Jun 1, 2022

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented May 29, 2022

Review and merge #10775 first

This PR adds SubmitValidatorRegistration for validator client. CLI will use that to submit validator registration to the beacon node. This PR also added a core function VerifyRegistrationSignature to verify registration signature is sound

@terencechain terencechain added the Builder PR or issue that supports builder related work label May 29, 2022
@terencechain terencechain self-assigned this May 29, 2022
@terencechain terencechain requested a review from a team as a code owner May 29, 2022 22:44
@terencechain terencechain force-pushed the validator-registration branch from c399bfd to 7245d42 Compare May 29, 2022 22:45
@terencechain terencechain force-pushed the validator-registration branch from 6ce75d9 to 35a7cd6 Compare May 29, 2022 22:57
@terencechain terencechain force-pushed the validator-registration branch from 4171d0f to 708fdd3 Compare May 31, 2022 19:45
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ( part of bigger submit registration feature with other PRs), E2E flaking.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 95c140b into develop Jun 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the validator-registration branch June 1, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builder PR or issue that supports builder related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants