Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back finalized info in new block log #10792

Merged
merged 3 commits into from
May 31, 2022
Merged

Add back finalized info in new block log #10792

merged 3 commits into from
May 31, 2022

Conversation

terencechain
Copy link
Member

Got requests from the team and others to add back finalized info in the synced new block... log with verbosity info because they are pretty useful

@terencechain terencechain added the UX cosmetic / user experience related label May 31, 2022
@terencechain terencechain requested a review from a team as a code owner May 31, 2022 13:50
@terencechain terencechain self-assigned this May 31, 2022
potuz
potuz requested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should leave them on debug as well

@terencechain
Copy link
Member Author

You should leave them on debug as well

Eh. Why did we have to duplicate. Refactored for the better

@prylabs-bulldozer prylabs-bulldozer bot merged commit 2de2000 into develop May 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-log branch May 31, 2022 17:44
@potuz potuz mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz potuz approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

@symbolpunk symbolpunk Awaiting requested review from symbolpunk symbolpunk is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
UX cosmetic / user experience related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @potuz