Batch Scenario Runs Into Single Test #10878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Jun 14, 2022
| } | ||
|
|
||
| func (r *testRunner) singleNodeOfflineMulticlient(epoch uint64, _ []*grpc.ClientConn) bool { | ||
| // This interceptor will define the multi scenario run for our minimal tests. |
There was a problem hiding this comment.
2) is missing from the comment
nisdas
commented
Jun 14, 2022
prestonvanloon
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
E2E Improvement
What does this PR do? Why is it needed?
We have many different scenarios that we want to run, however having a separate test for them increases flakiness significantly. Along with that we run these tests in multiple separate shards, if these are multiclient tests that are run they can significantly stress our test runner. The increased stress can lead to more flakes happening. Therefore this PR instead batches all these scenarios into a single test, that way we do not need to run so many tests and the test setup only needs to happen once.
Which issues(s) does this PR fix?
N.A
Other notes for review