submit lists of validator registrations #10882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Jun 15, 2022
|
@kasey build fails |
prestonvanloon
previously approved these changes
Jun 15, 2022
terencechain
dismissed stale reviews from prestonvanloon and themself
via
0d3791d
terencechain
force-pushed
the
val-reg-array
branch
from
3382eae to
0d3791d
Compare
terencechain
previously approved these changes
Jun 15, 2022
terencechain
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Updates the
registerValidatorbuilder API client code to submit multiple SignedValidatorRegistration objects wrapped in a json list.Other notes for review
If we fail to find a given validator key in the current state, we don't treat that as an error since it can happen for legit reasons (like a validator that hasn't had deposits processed yet). Service.RegisterValidator does currently return an error if there are zero validators ready to be registered, which is maybe not desirable.