Testutil refactor attestations #10952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
force-pushed
the
testutil-refactor-attestations
branch
from
9d58176 to
f23427f
Compare
saolyn
force-pushed
the
testutil-refactor-attestations
branch
from
f23427f to
f8b7812
Compare
rkapka
changed the title
rkapka
reviewed
Jun 29, 2022
testing/util/attestation.go
Outdated
Comment on lines
28
to
32
| type AttestationUtil struct{} | ||
|
|
||
| func NewAttestationUtil() *AttestationUtil { | ||
| return &AttestationUtil{} | ||
| } |
saolyn
force-pushed
the
testutil-refactor-attestations
branch
from
1fa3fd6 to
35ade20
Compare
rkapka
approved these changes
Jun 29, 2022
rkapka
added a commit
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactor
What does this PR do? Why is it needed?
This PR adds a receiver to
testing/util/attestation.gowhich creates a function hierarchy that is easier to navigate.Other notes for review