Simplify Push Proposer settings #11005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Cleanup
rauljordan
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
related to #10593
What does this PR do? Why is it needed?
This PR simplifies the calls we make to updating proposer settings such as fee recipient through APIs.
previously we call the prepare beacon proposer API and validator registration API when:
This PR removes the calls when
Validator Key status changesas it is consistently updated at the start of each epoch anyways. It is unlikely that the validator key will be chosen as a block proposer at the same time the proposer settings are updated, as it's rare for these settings to be updated after validator restart.