[Feature] - Store Only Blinded Beacon Blocks Post-Merge #11010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Jul 8, 2022
| @@ -537,6 +537,27 @@ func (s *Service) InsertSlashingsToForkChoiceStore(ctx context.Context, slashing | |||
| } | |||
| } | |||
|
|
|||
| func getBlockPayloadHash(blk interfaces.BeaconBlock) ([32]byte, error) { | |||
There was a problem hiding this comment.
This function needed edits to be future-proof. That is, it should be able to deal with blocks that have an execution payload or a payload header (blinded blocks)
…sm into feature-blinded-blocks
|
Some optimistic sync scenarios break here |
terencechain
reviewed
Jul 9, 2022
| @@ -68,7 +68,7 @@ type EngineCaller interface { | |||
| ExchangeTransitionConfiguration( | |||
| ctx context.Context, cfg *pb.TransitionConfiguration, | |||
| ) error | |||
| ExecutionBlockByHash(ctx context.Context, hash common.Hash) (*pb.ExecutionBlock, error) | |||
| ExecutionBlockByHash(ctx context.Context, hash common.Hash, withTxs bool) (*pb.ExecutionBlock, error) | |||
There was a problem hiding this comment.
I know we don't like bool flag as argument but I think it's fine here
This was referenced Jul 11, 2022
Co-authored-by: terencechain <terence@prysmaticlabs.com>
…sm into feature-blinded-blocks
| @@ -123,6 +121,10 @@ var ( | |||
| Name: "enable-gossip-batch-aggregation", | |||
| Usage: "Enables new methods to further aggregate our gossip batches before verifying them.", | |||
| } | |||
| EnableOnlyBlindedBeaconBlocks = &cli.BoolFlag{ | |||
There was a problem hiding this comment.
Can this not be exported?
Suggested change
| EnableOnlyBlindedBeaconBlocks = &cli.BoolFlag{ | |
| enableOnlyBlindedBeaconBlocks = &cli.BoolFlag{ |
There was a problem hiding this comment.
@terencechain it's used in a DB method that tells the user via a log to remove the flag if they want to resync full blocks. Without exporting it, i would have to hardcode the flag name as a string, which can change
prestonvanloon
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
In a design document here, we outline how important it is that Prysm only stores blinded beacon blocks post-merge in the database.
if we do not have this feature, we foresee the storage requirements of Prysm growing significantly over time. Today, the avg Ethereum block size is 82Kb. Assuming we get a block every 10 seconds, this means 492Kb per minute, or 29.52 Mb per hour. Given there are 8760 hours per year, this could amount to 8760*29.52Mb = 258Gb per year that needs to be stored in Geth and in Prysm. It is unreasonable to store this same data twice, which is why this feature is important for us to ship.
https://etherscan.io/chart/blocksize see here for avg blocksize data at the time of writing, on July 5th, 2022.
This PR adds a feature flag
--enable-only-blinded-beacon-blockswhich stores Bellatrix beacon blocks as blinded format in our database. This will change our behavior with p2p and API requests to reconstruct full Bellatrix blocks from blinded format.Which issues(s) does this PR fix?
Fixes #10589