Don't create payload with same timestamp as terminal block #11129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Jul 28, 2022
Comment on lines
+263
to
+273
|
|
||
| // If terminal block has time same timestamp or greater than transition time, | ||
| // then the node violates the invariant that a block's timestamp must be | ||
| // greater than its parent's timestamp. Execution layer will reject | ||
| // a fcu call with such payload attributes. It's best that we return `None` in this a case. | ||
| parentReachedTTD := parentTotalDifficulty.Cmp(terminalTotalDifficulty) >= 0 | ||
| if !parentReachedTTD { | ||
| if blk.Time >= transitionTime { | ||
| return nil, false, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
I am worried about this solution, the transition time being passed to this function is purely on the CL side (you're passing a slot time) while the condition we want to prevent is that the block timestamp is not that of the TTD. Why not simply comparing the timestamp of these two blocks here instead of comparing to transitionTime?
terencechain
force-pushed
the
invalid-terminal-timestamp
branch
from
fed1058 to
80db733
Compare
potuz
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11069
This PR fixes an issue where prysm will create a transition block where
block.execution_payload().timestamp == terminal_block.timestampand such block would have failedforkchoiceUpdatecall